Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub coverage workflow #3288

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix GitHub coverage workflow #3288

merged 1 commit into from
Sep 18, 2023

Conversation

HalidOdat
Copy link
Member

For some reason tarpaulin no longer recognises the "Xml" format output spelled with a upper case 'X'.

Change Xml to xml

Error:

Run actions-rs/cargo@v1
/home/runner/.cargo/bin/cargo tarpaulin --workspace --features intl --ignore-tests --engine llvm --out Xml
error: invalid value 'Xml' for '--out [<FMT>...]'
Error:   [possible values: json, stdout, xml, html, lcov]

  tip: a similar value exists: 'xml'

For more information, try '--help'.
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 2

@HalidOdat
Fix GitHub coverage workflow
64cc7aa 
For some reason `tarpaulin` no longer recognises the "Xml" format
output spelled with a upper case 'X'.

Change `Xml` to `xml`
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,420 95,420 0
Passed 75,078 75,078 0
Ignored 19,352 19,352 0
Failed 990 990 0
Panics 0 0 0
Conformance 78.68% 78.68% 0.00%

@HalidOdat HalidOdat added bug Something isn't working github_actions Pull requests that update Github_actions code labels Sep 18, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Sep 18, 2023
@HalidOdat HalidOdat requested a review from a team September 18, 2023 13:01
@HalidOdat HalidOdat marked this pull request as ready for review September 18, 2023 13:01
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (3c15e59) 50.30% compared to head (64cc7aa) 50.31%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3288      +/-   ##
==========================================
+ Coverage   50.30%   50.31%   +0.01%     
==========================================
  Files         436      436              
  Lines       42656    42604      -52     
==========================================
- Hits        21456    21438      -18     
+ Misses      21200    21166      -34

see 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 9c7e10c Sep 18, 2023
@HalidOdat HalidOdat deleted the fix/coverage-workflow branch September 18, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nekevss nekevss nekevss approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @jedel1043 @nekevss